GH-49369: [C++][R] Deal with validating libtool again#49370
GH-49369: [C++][R] Deal with validating libtool again#49370jonkeane merged 6 commits intoapache:mainfrom
Conversation
|
@github-actions crossbow submit test-r-install-local |
|
Revision: b6fa4e7 Submitted crossbow builds: ursacomputing/crossbow @ actions-dd37c5e22c
|
|
@github-actions crossbow submit test-r-install-local |
|
Revision: dcc373d Submitted crossbow builds: ursacomputing/crossbow @ actions-cb360883d6
|
bdafffa to
fd2af48
Compare
|
The failures are either on main (macos 14) or transient (ubuntu gcc) |
|
This is something that showed up on CRAN: the red M1Mac on https://cran.r-project.org/web/checks/check_results_arrow.html. And then separately I also received this from one of the CRAN maintainers: The whole reason for this detection issue is because some CRAN machines had GNU We test this in crossbow jobs installing macos locally https://github.com/ursacomputing/crossbow/actions/runs/22282130627/job/64454329380#step:9:790 which we setup to use GNU I am also going to add a print if I can to the cmake to also print out the version string we get when it errors so that we didn't need one of the CRAN maintainers to send us the string. |
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
|
@github-actions crossbow submit test-r-install-local |
|
Revision: ad966fa Submitted crossbow builds: ursacomputing/crossbow @ actions-69584c2a2e
|
ad966fa to
7f0f2a6
Compare
|
@github-actions crossbow submit test-r-install-local |
|
Revision: 7f0f2a6 Submitted crossbow builds: ursacomputing/crossbow @ actions-2fb3dea162
|
### Rationale for this change Deal with bespoke frameworks on CRAN machines, ensure we can detect Apple-provided `libtool` as opposed to GNU `libtool`. Modernize cmake. ### What changes are included in this PR? Use `VALIDATOR` to validate `libtool`, a slightly more flexible regex ### Are these changes tested? Yes ### Are there any user-facing changes? No, well just one. * GitHub Issue: #49369 Lead-authored-by: Jonathan Keane <jkeane@gmail.com> Co-authored-by: Sutou Kouhei <kou@cozmixng.org> Signed-off-by: Jonathan Keane <jkeane@gmail.com>
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit cbe2618. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
Deal with bespoke frameworks on CRAN machines, ensure we can detect Apple-provided
libtoolas opposed to GNUlibtool. Modernize cmake.What changes are included in this PR?
Use
VALIDATORto validatelibtool, a slightly more flexible regexAre these changes tested?
Yes
Are there any user-facing changes?
No, well just one.
libtoolchecking #49369